Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the spec to use HTML's navigables instead of browsing contexts #729

Merged
merged 6 commits into from
Jul 17, 2024

Conversation

OrKoN
Copy link
Contributor

@OrKoN OrKoN commented Jun 13, 2024

This PR updates the specification to define interactions with browsing contexts in terms of HTML spec's navigables without changing the API (which keeps using "browsingContext" and "context" to refer to navigables).

Closes #91


Preview | Diff

@OrKoN OrKoN force-pushed the orkon/navigable branch 4 times, most recently from d492c61 to e09af2b Compare June 13, 2024 17:41
Copy link
Member

@jgraham jgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looking good, thanks! Just a few cases where we're linking to the wrong thing or inventing a concept that doesn't seem to exist.

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
@OrKoN OrKoN requested a review from jgraham June 17, 2024 18:26
@OrKoN OrKoN changed the title Start renaming browsing contexts Change the spec to use HTML's navigables instead of browsing contexts Jun 19, 2024
@OrKoN
Copy link
Contributor Author

OrKoN commented Jun 19, 2024

@jgraham PTAL again

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
@OrKoN OrKoN closed this Jul 10, 2024
@OrKoN OrKoN reopened this Jul 10, 2024
@css-meeting-bot
Copy link
Member

The Browser Testing and Tools Working Group just discussed Navigable rewrite, and agreed to the following:

  • ACTION: David to find out who will be remote for the meetings [1]
  • ACTION: Please read the issue and leave comments (all) [2]
The full IRC log of that discussion <AutomatedTester> topic: Navigable rewrite
<AutomatedTester> github: https://github.com//pull/729
<jgraham> q+
<AutomatedTester> orkon: the last time we were updating to use navigables instead of contexts
<AutomatedTester> ... it would be good if folks can review it
<AutomatedTester> ack next
<AutomatedTester> jgraham: I looked earlier and it mostly looks right. I will try read it again very soon. Thanks for doing all the editorial work
<AutomatedTester> orkon: I've updated links etc
<orkon> present-
<jgraham> RSSAgent make minutes
<jgraham> zakim, bye
<Zakim> leaving. As of this point the attendees have been AutomatedTester, jimevans, orkon, jgraham, jdescottes, sasha, jugglinmike
<jgraham> RRSAgent make minutes
<jgraham> RRSAgent: make minutes
<RRSAgent> I have made the request to generate https://www.w3.org/2024/07/10-webdriver-minutes.html jgraham
<jgraham> RRSAgent: bye
<RRSAgent> I see 2 open action items saved in https://www.w3.org/2024/07/10-webdriver-actions.rdf :
<RRSAgent> ACTION: David to find out who will be remote for the meetings [1]
<RRSAgent> recorded in https://www.w3.org/2024/07/10-webdriver-irc#T16-12-16
<RRSAgent> ACTION: Please read the issue and leave comments (all) [2]
<RRSAgent> recorded in https://www.w3.org/2024/07/10-webdriver-irc#T16-45-19

@OrKoN OrKoN closed this Jul 11, 2024
@OrKoN OrKoN reopened this Jul 11, 2024
Copy link
Member

@jgraham jgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really close, just a few small issues that I noticed.

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Show resolved Hide resolved
Co-authored-by: jgraham <james@hoppipolla.co.uk>
OrKoN and others added 2 commits July 11, 2024 13:46
Co-authored-by: jgraham <james@hoppipolla.co.uk>
Copy link
Member

@jgraham jgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@w3cbot
Copy link

w3cbot commented Jul 17, 2024

jgraham marked as non substantive for IPR from ash-nazg.

@jgraham
Copy link
Member

jgraham commented Jul 17, 2024

Since this is basically a (large) editorial change, and the underlying problem is that rejoining the group is taking some time, I this this should be fine to merge.

@jgraham jgraham merged commit 712c17f into main Jul 17, 2024
13 checks passed
@jgraham jgraham deleted the orkon/navigable branch July 17, 2024 10:42
github-actions bot added a commit that referenced this pull request Jul 17, 2024
…#729)

SHA: 712c17f
Reason: push, by jgraham

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
domenic pushed a commit to whatwg/html that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update spec to define things in terms of Navigables
5 participants