Actions pointer additional properties #1417
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotiusmargo
requested review from
andreastt,
AutomatedTester,
jgraham and
shs96c
as code owners
timotiusmargo
force-pushed
the
actions-pointer-additional-properties
branch
from
ee208e3
to
9fb6731
Compare
W3C Pointer Events defined additional pointer properties (pressure, contact geometry, tilt, etc.) to the PointerEvent interface that reflects new interactions with pointer devices like touch and pen. Update the WebDriver actions to support these additional properties.
Create optional properties table Update pointer actions dispatch sections to take the additional properties into account
timotiusmargo
force-pushed
the
actions-pointer-additional-properties
branch
from
9fb6731
to
f7101d4
Compare
|
I wanted to pop by and see if @AutomatedTester or @shs96c had a chance to look at this one yet. LGTM. |
|
@timotiusmargo @thejohnjansen This looks good. Are there tests to go with this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actions: add additional pointer properties
Add pointer additional properties such as pressure, contact geometry, tilt, etc. to the WebDriver pointer actions in accordance with the latest W3C PointerEvent interface. This additional properties enables automating/simulating new interactions with pointer devices like touch and pen.
Preview | Diff