-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert spec to Bikeshed #1514
Draft
foolip
wants to merge
17
commits into
w3c:master
Choose a base branch
from
foolip:bikeshed
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Convert spec to Bikeshed #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foolip
force-pushed
the
bikeshed
branch
7 times, most recently
from
June 3, 2020 13:16
d345143
to
79788b2
Compare
Done using this "elegant" replacement: ```js source.replace(/(<h[1-6])>(.*?)(<\/h[1-6]>)/g, (_, p1, p2, p3) => `${p1} id=${p2.replace(/<dfn.*?>/, '').replace('</dfn>', '').toLowerCase().replace(/\s+/g, '-')}>${p2}${p3}`) ```
> sed -i '' 's/data-lt=/lt=/g' index.bs This leaves a data-lt-noDefault attributes, untouched for now.
This is necessary because ReSpec and Bikeshed don't have the same behavior. ReSpec uses the text content as an alternative by default, while Bikeshed uses only the provided lt, if any is given: https://github.com/w3c/respec/wiki/data-lt https://tabatkins.github.io/bikeshed/#changing-lt
To minimize differences in the transition
ReSpec and Bikeshed requires different escaping here...
This mainly silences warnings about unused definitions.
The licenses of both repos are the same.
this seems like a not amazing use of time... ReSpec supports the same features as BikeShed. See #1588 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1462.