This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Add the 'Last-Modified' header to the default file handler #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default file handler is missing the
Last-Modified
header, this doesn't allow the browser to cache any resource.Found this problem with a mozmill/mutt test that was checking "http-on-examine-response" vs "http-on-examine-cached-response" observers, and in the case of wptserve we never got any resource from the local cache.
This PR fixes the problem by setting this header.
@jgraham please review when you have time. Thanks