Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

Add the 'Last-Modified' header to the default file handler #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andreieftimie
Copy link
Contributor

The default file handler is missing theLast-Modified header, this doesn't allow the browser to cache any resource.

Found this problem with a mozmill/mutt test that was checking "http-on-examine-response" vs "http-on-examine-cached-response" observers, and in the case of wptserve we never got any resource from the local cache.

This PR fixes the problem by setting this header.

@jgraham please review when you have time. Thanks

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/1967

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants