Redirect un-encoded player URLs if possible #866
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francislavoie
force-pushed
the
player-hash-redirect
branch
2 times, most recently
from
ec140eb to
59fd33a
Compare
francislavoie
force-pushed
the
player-hash-redirect
branch
from
59fd33a to
8fd7537
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a fun hack.
For example, you might request https://w3champions.com/player/Ruhigengeist#1200 but this results in a broken page since no user is found. We can be smarter about this because the
#is the "fragment" (aka "hash") part of the URL, so we can redirect on mount to the correct URL i.e. https://w3champions.com/player/Ruhigengeist%231200 and it can even work if there's a path like/matchesat the end.