-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Faucet bot milestone delivery. #941
Conversation
Hey @StringNick! I will make an external evaluation later, just create a draft PR #942 now. I will ping you when I finish it. |
Hi @StringNick , I've looked briefly at your documentation and it seems to be missing the |
|
yes I loose commit I suppose, sorry. I will fix testing section, variables seciton is available, I will recheck links.
Will fix it too. |
@Whisker17 Hi, I hope I fix everything, If u have any question how to add matrix/discord bot credentials write it. |
Hey @StringNick, thanks for your update, I just had a test for your docker-compose and found something wrong with the bot. |
@Whisker17, I faced this problem today, its because substrate start-up time is too long, u need wait when substrate fully started and than start a bot, I can write it in README |
What do you mean fully started? Blocks fully synchronized? I just tried to run the bot compiled locally, and the substrate was also syncing blocks, but still panic. |
If it's screenshot from local, I saw address ws://substrate:9944, it's used only in docker compose, I can record a video guide, if I trying locally change address in config.toml |
Oh @StringNick that will be awesome! Appreciate your work, btw, could you also add some guides for the faucet guides of discord and matrix, thank you! |
Thank you @Whisker17 , I wrote it in header, for discord many guides with video, just create a bot, generate token, add bot to channel. |
Hey @StringNick , just have a try and the substrate node works well, but the bot service still can't work, it panics all the time. |
@Whisker17 In ur logs he can't connect, maybe it's something with ur docker network? Can u ping substrate in docker container (from redis service for example) or telnet it in container, because it's strange |
Finished my evaluation #942 , lgtm. And thanks for @StringNick's help, appreciate it so much! |
Thanks @StringNick for the delivery and @Whisker17 for the evaluation. Still looking it over but in the meantime, can you update the license file to replace boilerplate with your copyright date and owner name? Thanks! |
@StringNick your evaluation has been passed and I was able to reproduce the results. I agree the docs could be a bit better as they are sparse and I had to fumble around with getting the go modules installed and getting Docker compose file to work. Once the license file change is implemented I will merge the milestone. Overall great job! |
@Whisker17 @keeganquigley Thank you for reviewing, I pushed updated license. |
Thanks @StringNick congrats on completing the milestone. I will forward your invoice for processing. |
We noticed that this is the last milestone of your project. Congratulations on completing your grant! 🎊 |
@StringNick Actually I am not seeing the W3F VAT ID on your invoice. Can you update the invoice to include it and resubmit? If you need it you can find it here: https://web3.foundation/legal-disclosures/ Thanks! |
@keeganquigley VAT ID is Tax number I wrote it, check in bottom of invoice, or I need to rename from |
Hi @StringNick I'm not sure what you mean, as the tax number shown is not the same as the VAT no. that is listed here. It should match the one that starts with "CHE" Please check again, thank you. |
yes I named it wrong(its not tax number, but yes I put a vat number), vat number in Serbia is just 9 numbers, CHE is only for Switzerland? (code country is only in EU?) |
@StringNick okay thanks good to know for Serbia. However, the Web3 Foundation VAT ID should also be present, which starts with CHE. You can include this below the Serbia one. |
Sorry we have misunderstanding, I fixed invoice and sent it |
Thanks @StringNick much appreciated. I have forwarded the new invoice for processing. |
Milestone Delivery Checklist
Link to the application pull request: w3f/Grants-Program#1758