Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Faucet bot milestone delivery. #941

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Add Faucet bot milestone delivery. #941

merged 1 commit into from
Aug 1, 2023

Conversation

StringNick
Copy link
Contributor

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • The invoice form 📝 has been filled out for this milestone.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, the payment will be transferred to the BTC/ETH/fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1758

@Whisker17
Copy link
Contributor

Hey @StringNick! I will make an external evaluation later, just create a draft PR #942 now. I will ping you when I finish it.

@Whisker17
Copy link
Contributor

Whisker17 commented Jul 29, 2023

Hi @StringNick , I've looked briefly at your documentation and it seems to be missing the test, variables, and environments sections you've mentioned, is there something missing from the documentation?

@Whisker17
Copy link
Contributor

docker-compose -up -d should be docker-compose up -d

@StringNick
Copy link
Contributor Author

StringNick commented Jul 29, 2023

@Whisker17

Hi @StringNick , I've looked briefly at your documentation and it seems to be missing the test, variables, and environments sections you've mentioned, is there something missing from the documentation?

yes I loose commit I suppose, sorry. I will fix testing section, variables seciton is available, I will recheck links.

docker-compose -up -d should be docker-compose up -d

Will fix it too.

@StringNick
Copy link
Contributor Author

@Whisker17 Hi, I hope I fix everything, If u have any question how to add matrix/discord bot credentials write it.

@Whisker17
Copy link
Contributor

Hey @StringNick, thanks for your update, I just had a test for your docker-compose and found something wrong with the bot.
image
You can see from this screenshot, the bot panics because of the refusion of connecting to the substrate node.

@StringNick
Copy link
Contributor Author

@Whisker17, I faced this problem today, its because substrate start-up time is too long, u need wait when substrate fully started and than start a bot, I can write it in README

@Whisker17
Copy link
Contributor

@Whisker17, I faced this problem today, its because substrate start-up time is too long, u need wait when substrate fully started and than start a bot, I can write it in README

What do you mean fully started? Blocks fully synchronized? I just tried to run the bot compiled locally, and the substrate was also syncing blocks, but still panic.
image

@StringNick
Copy link
Contributor Author

@Whisker17, I faced this problem today, its because substrate start-up time is too long, u need wait when substrate fully started and than start a bot, I can write it in README

What do you mean fully started? Blocks fully synchronized? I just tried to run the bot compiled locally, and the substrate was also syncing blocks, but still panic. image

If it's screenshot from local, I saw address ws://substrate:9944, it's used only in docker compose, I can record a video guide, if I trying locally change address in config.toml

@Whisker17
Copy link
Contributor

Oh @StringNick that will be awesome! Appreciate your work, btw, could you also add some guides for the faucet guides of discord and matrix, thank you!

@StringNick
Copy link
Contributor Author

StringNick commented Jul 31, 2023

Thank you @Whisker17 , I wrote it in header, for discord many guides with video, just create a bot, generate token, add bot to channel.
For matrix is more easy, create an account, using for example this link https://app.element.io/#/register, invite this account to channel where u want receive drip, provide credentials to config.toml (login/password).
Video of start-up docker-compose demo with request drip through matrix: https://drive.google.com/file/d/1GvGX4HkIEtjziAam_xP8pZh6A2o1yI_f/view?usp=sharing

@keeganquigley keeganquigley self-assigned this Jul 31, 2023
@Whisker17
Copy link
Contributor

Hey @StringNick , just have a try and the substrate node works well, but the bot service still can't work, it panics all the time.
image

@StringNick
Copy link
Contributor Author

StringNick commented Jul 31, 2023

@Whisker17 In ur logs he can't connect, maybe it's something with ur docker network? Can u ping substrate in docker container (from redis service for example) or telnet it in container, because it's strange

@Whisker17
Copy link
Contributor

seems nothing wrong with the connection between redis and substrate node.
image

@StringNick
Copy link
Contributor Author

StringNick commented Jul 31, 2023

seems nothing wrong with the connection between redis and substrate node. image

I think u need to ping a domain address, in configuration u use substrate, we can go in messenger(matrix/discord), and I will try to figure out a problem

@Whisker17
Copy link
Contributor

Finished my evaluation #942 , lgtm. And thanks for @StringNick's help, appreciate it so much!

@keeganquigley
Copy link
Contributor

Thanks @StringNick for the delivery and @Whisker17 for the evaluation. Still looking it over but in the meantime, can you update the license file to replace boilerplate with your copyright date and owner name? Thanks!

@keeganquigley
Copy link
Contributor

@StringNick your evaluation has been passed and I was able to reproduce the results. I agree the docs could be a bit better as they are sparse and I had to fumble around with getting the go modules installed and getting Docker compose file to work. Once the license file change is implemented I will merge the milestone.

Overall great job!

@StringNick
Copy link
Contributor Author

@Whisker17 @keeganquigley Thank you for reviewing, I pushed updated license.
I will try to create a new milestone where I will improve docs, add e2e tests (its a little bit harder than unit here) and add new platforms.

@keeganquigley
Copy link
Contributor

keeganquigley commented Aug 1, 2023

Thanks @StringNick congrats on completing the milestone. I will forward your invoice for processing.

@keeganquigley keeganquigley merged commit cc5b352 into w3f:master Aug 1, 2023
6 checks passed
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

We noticed that this is the last milestone of your project. Congratulations on completing your grant! 🎊

So, where to from here? First of all, you should join our Grants Community chat, if you haven't already, so we can stay in touch.
If you are looking for continuative support for your project, there are quite a few options. The main goal of the W3F grants program is to support research as well as early-stage technical projects. If your project still falls under one of those categories, you might want to apply for a follow-up grant. However, depending on your goals and project status, there are other support programs in our ecosystem that might be better suited as the next step. For example, projects with a Business Case/Token should look into the Substrate Builders Program or VC Funding. Common Good projects have a good chance of receiving Treasury Funding.

For a more comprehensive list, see our Alternative Funding page. Let us know if you have any questions regarding the above. We are more than happy to point you to additional resources and help you determine the best course of action.
Lastly, we hope your W3F grant was a success and we want to thank you for being part of the journey!

@keeganquigley
Copy link
Contributor

@StringNick Actually I am not seeing the W3F VAT ID on your invoice. Can you update the invoice to include it and resubmit? If you need it you can find it here: https://web3.foundation/legal-disclosures/

Thanks!

@StringNick
Copy link
Contributor Author

StringNick commented Aug 1, 2023

@keeganquigley VAT ID is Tax number I wrote it, check in bottom of invoice, or I need to rename from tax number to vat id?

@keeganquigley
Copy link
Contributor

Hi @StringNick I'm not sure what you mean, as the tax number shown is not the same as the VAT no. that is listed here. It should match the one that starts with "CHE"

Please check again, thank you.

@StringNick
Copy link
Contributor Author

StringNick commented Aug 1, 2023

Hi @StringNick I'm not sure what you mean, as the tax number shown is not the same as the VAT no. that is listed here. It should match the one that starts with "CHE"

Please check again, thank you.

yes I named it wrong(its not tax number, but yes I put a vat number), vat number in Serbia is just 9 numbers, CHE is only for Switzerland? (code country is only in EU?)

@keeganquigley
Copy link
Contributor

@StringNick okay thanks good to know for Serbia. However, the Web3 Foundation VAT ID should also be present, which starts with CHE. You can include this below the Serbia one.

@StringNick
Copy link
Contributor Author

@StringNick okay thanks good to know for Serbia. However, the Web3 Foundation VAT ID should also be present, which starts with CHE. You can include this below the Serbia one.

Sorry we have misunderstanding, I fixed invoice and sent it

@keeganquigley
Copy link
Contributor

Thanks @StringNick much appreciated. I have forwarded the new invoice for processing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants