Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for copying child relation model instances with inheritance models #166

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix for copying child relation model instances with inheritance models #166

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8d14b3
Fix for copying child relation model instances with inheritance models
JakubMusil Sep 15, 2022
c91fb76
Update models.py
JakubMusil Nov 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions modelcluster/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,11 @@ def copy_child_relation(self, child_relation, target, commit=False, append=False
for child_object in source_manager.all().order_by('pk'):
old_pk = child_object.pk
is_saved = old_pk is not None
if isinstance(child_object, ClusterableModel):
child_object, _ = child_object.copy_cluster()
child_object.pk = None
child_object.id = None
child_object._state.adding = True
setattr(child_object, parental_key_name, target.id)
target_manager.add(child_object)

Expand Down