Fix: Field with the same name as a lookup in FILTER_EXPRESSION_TOKENS causes crash when filtering with implicit exact
#184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ababic
force-pushed
the
fix/171-field-names-swallowed-when-match-an-expression
branch
9 times, most recently
from
18568cc
to
8dc234b
Compare
ababic
changed the title
exact
ababic
force-pushed
the
fix/171-field-names-swallowed-when-match-an-expression
branch
3 times, most recently
from
ba4b189
to
04e435d
Compare
…relationshipvalueencountered' does
ababic
force-pushed
the
fix/171-field-names-swallowed-when-match-an-expression
branch
from
04e435d
to
bc3e01a
Compare
|
@gasman Any chance of a review on this one? I have plans to fix some additional issues with |
…versal isn't possible
ababic
force-pushed
the
fix/171-field-names-swallowed-when-match-an-expression
branch
from
bc3e01a
to
9cb175d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #172, which fixes #171 in a slightly different way.
Using
get_model_field()here means the issue shouldn't surface when filtering on related fields either, which is the case I stumbled into recently on a client project.I've also fixed an issue with
extract_field_value()here, where it chokes when encountering a null FK value while traversing to a related field (get_model_field()supports this kind of traversal, so we should really be handling that)