Removed bakerydemo-settings-local.py.example

[jsma]

This file never worked, it caused a circular import loop since it attempts to from bakerydemo.settings.dev import * but the dev settings does:

try:
    from .local import *  # noqa
except ImportError:
    pass

Fixed the setup.sh script to set the correct settings module environment variable

Fixes #68

[saevarom]

Thanks @jsma !

If you remove this file a fresh install will no longer connect to the database, since the code to load the env variablies lives in the bakerydemo-settings-local.py.example. This was probably working for a previous install since the bakerydemo/settings/local.py was already populated with the necessary code.

I would suggest amending the bakerydemo-settings-local.py.example instead so that in only includes code for connecting to the database.

[saevarom]

This line should probably go

[saevarom]

This code is needed for fresh installs so that we have a working local.py.

[jsma]

The database connection setting is actually set here:

docker-wagtail-develop/docker-compose.yml

Line 21 in 0d4b9c6

DATABASE_URL: "postgres://wagtail:changeme@db/wagtail"

bakerydemo's settings.base picks this environment variable up here:

if "DATABASE_URL" in os.environ:
    DATABASES = {"default": dj_database_url.config(conn_max_age=500)}

[saevarom]

Ok, I see that now that it is being picked up in he base settings. Your statement about this never working is wrong, though, since that code change is only 7 months old.

But anyway, thanks for your work on this. Will test again later.

[jsma]

I'm sorry if my word choice seemed insulting! bakerydemo's settings.dev has not changed in 9 months, it was doing from .local import * at the time bakerydemo-settings-local.py.example was introduced in this project. DATABASE_URL was added to the docker-compose.yml two years ago, so between this environment variable already existing and the try/except in settings.dev swallowing the import loop exception, the error was never noticed.

[saevarom]

No worries. Just be mindful we're building on people's volunteer work and mistakes get sometimes made. It happens.

I've tested this on an existing setup and a fresh setup and this works great, thank you!