feat: queue notification

.vscode/settings.json

@@ -3,6 +3,7 @@
 		"adminjs",
 		"aicommit",
 		"claudeai",
+		"fastq",
 		"healthz",
 		"nofollow",
 		"openai",

package.json

@@ -37,6 +37,7 @@
 		"dotenv": "^16.4.5",
 		"express": "^4.19.2",
 		"express-rate-limit": "^7.3.1",
+		"fastq": "^1.17.1",
 		"helmet": "^7.1.0",
 		"openai": "^4.52.7",
 		"typescript": "^5.5.3"

src/middleware.ts

@@ -9,7 +9,7 @@ import {
 import h from 'helmet';
 import { appConfig } from './config';
 import { rateLimit } from 'express-rate-limit';
-import { logger, statusCode, html } from './util';
+import { logger, statusCode, html, queueNotification } from './util';
 import { NextFunction, Request, Response } from 'express';
 
 export function helmet() {
@@ -70,46 +70,8 @@ export function errorMiddleware() {
 	]);
 
 	return async (error: Error, req: Request, res: Response, next: NextFunction) => {
-		// if (appConfig.NODE_ENV === 'production' && !(error instanceof NotFoundError)) {
 		if (appConfig.NODE_ENV === 'production') {
-			try {
-				const n = await fetch(appConfig.NOTIFY_URL, {
-					method: 'POST',
-					headers: {
-						'Content-Type': 'application/json',
-						'X-API-KEY': appConfig.NOTIFY_X_API_KEY,
-					},
-					body: JSON.stringify({
-						message: `Error: ${error.message}`,
-						details: JSON.stringify(
-							{
-								request: {
-									method: req.method,
-									url: req.url,
-									headers: req.headers,
-									query: req.query,
-									body: req.body,
-								},
-								error: {
-									name: error?.name,
-									message: error?.message,
-									stack: error?.stack,
-									cause: error?.cause,
-								},
-							},
-							null,
-							2,
-						),
-					}),
-				});
-
-				if (!n.ok) {
-					const text = await n.text();
-					throw new Error(`Notification service responded with status ${n.status}: ${text}`);
-				}
-			} catch (error) {
-				logger.error('Failed to send error notification', error);
-			}
+			queueNotification(req, error);
 		}
 
 		for (const [ErrorClass, statusCode] of errorMap) {

src/util.ts

@@ -1,7 +1,57 @@
+import fastq from 'fastq';
 import { Request } from 'express';
 import { styleText } from 'node:util';
+import { appConfig } from './config';
 import { CacheType, ConfigItem, Logger } from './types';
 
+// @ts-expect-error - fix this
+const queue = fastq.promise(sendNotification, 1);
+
+export function queueNotification(req: Request, error: Error) {
+	queue.push({ req, error });
+}
+
+export async function sendNotification(req: Request, error: Error) {
+	try {
+		const n = await fetch(appConfig.NOTIFY_URL, {
+			method: 'POST',
+			headers: {
+				'Content-Type': 'application/json',
+				'X-API-KEY': appConfig.NOTIFY_X_API_KEY,
+			},
+			body: JSON.stringify({
+				message: `Error: ${error?.message}`,
+				details: JSON.stringify(
+					{
+						request: {
+							method: req.method,
+							url: req.url,
+							headers: req.headers,
+							query: req.query,
+							body: req.body,
+						},
+						error: {
+							name: error?.name,
+							message: error?.message,
+							stack: error?.stack,
+							cause: error?.cause,
+						},
+					},
+					null,
+					2,
+				),
+			}),
+		});
+
+		if (!n.ok) {
+			const text = await n.text();
+			logger.error(`Notification service responded with status ${n.status}: ${text}`);
+		}
+	} catch (error) {
+		logger.error('Failed to send error notification', error);
+	}
+}
+
 export const statusCode = Object.freeze({
 	INTERNAL_SERVER_ERROR: 500 as number,
 	FORBIDDEN: 403,