Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: log error and stacktrace when panic in goroutine #1225

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

qfrank
Copy link
Collaborator

@qfrank qfrank commented Sep 23, 2024

relate comment1 / comment2

relate issue

@qfrank qfrank self-assigned this Sep 23, 2024
@qfrank qfrank changed the title feat_: log error and stacktrace when panic in goroutine feat: log error and stacktrace when panic in goroutine Sep 23, 2024
waku/v2/api/filter/filter.go Outdated Show resolved Hide resolved
waku/v2/utils/logger.go Outdated Show resolved Hide resolved
Copy link
Member

@richard-ramos richard-ramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qfrank qfrank merged commit 8b0e031 into master Sep 25, 2024
12 checks passed
@qfrank qfrank deleted the feat/log_and_panic branch September 25, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants