Feat: filter select peer for sharding #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaitanyaprem
changed the base branch from
master
to
feat/autoshard-lightpush
Jenkins BuildsClick to see older builds (18)
|
2 tasks
|
@SionoiS , I have noticed that in nwaku while selecting peers from serviceSlots the filtering is not done as per shards. JFYI in case it is not already being tracked. |
3 tasks
Ah! good catch I didn't notice that. Thanks! |
richard-ramos
approved these changes
Sep 29, 2023
chaitanyaprem
added a commit
that referenced
this pull request
Sep 29, 2023
* feat: update lightpush API to make pubSubTopic optional as per autosharding * Extract contentFilter and subscriptions out of filter to reuse in relay (#779) * chore: extract contentFilter outside filter package * chore: move subscription outside of filter so that it can be modified and reused for relay * Feat: filter select peer for sharding (#783) * update selectPeer to support pubsubTopic based selection
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current selectPeer functionality works without taking sharding into consideration. #680
This enhances to take pubSubTopic or contentTopic into consideration during peer selection.
Changes
Tests
Ran all existing unit tests.
Added few new ones to validate functionality.