Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return errors in FilterSubscribeOption #794

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

richard-ramos
Copy link
Member

Description

Make the options for filter subscription return an err

@status-im-auto
Copy link

status-im-auto commented Oct 6, 2023

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 7d4b71d #1 2023-10-06 08:14:31 ~2 min nix-flake 📄log
✔️ 7d4b71d #1 2023-10-06 08:14:49 ~2 min linux 📦deb
✖️ 7d4b71d #1 2023-10-06 08:14:54 ~2 min tests 📄log
✖️ 7d4b71d #1 2023-10-06 08:15:19 ~3 min tests 📄log
✔️ 7d4b71d #1 2023-10-06 08:16:36 ~4 min android 📦tgz
✔️ 7d4b71d #1 2023-10-06 08:17:06 ~4 min ios 📦tgz
✔️ 3e84253 #2 2023-10-06 08:21:12 ~1 min linux 📦deb
✔️ 3e84253 #2 2023-10-06 08:21:46 ~1 min tests 📄log
✔️ 3e84253 #2 2023-10-06 08:21:59 ~1 min nix-flake 📄log
✔️ 3e84253 #2 2023-10-06 08:22:07 ~1 min tests 📄log
✔️ 3e84253 #2 2023-10-06 08:23:20 ~3 min android 📦tgz
✔️ 3e84253 #2 2023-10-06 08:23:34 ~3 min ios 📦tgz

Copy link
Collaborator

@romanzac romanzac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've retested, and got en error as expected.

Thanks.

@richard-ramos richard-ramos merged commit 3aa477c into master Oct 7, 2023
11 checks passed
@richard-ramos richard-ramos deleted the fix/filter-subscribe-options branch October 7, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants