Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): query time comparison and max rows per page #800

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

richard-ramos
Copy link
Member

Description

Fixes an issue reported by @fbarbu15 where a store was not including a message whose timestamp matched the starttime of the query, and also sets the max page size to 20 to match nwaku

@status-im-auto
Copy link

status-im-auto commented Oct 12, 2023

Jenkins Builds

Click to see older builds (6)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6ad38a6 #1 2023-10-12 12:46:35 ~1 min nix-flake 📄log
✔️ 6ad38a6 #1 2023-10-12 12:47:06 ~2 min linux 📦deb
✖️ 6ad38a6 #1 2023-10-12 12:47:53 ~3 min tests 📄log
✔️ 6ad38a6 #1 2023-10-12 12:48:46 ~4 min android 📦tgz
✔️ 6ad38a6 #1 2023-10-12 12:50:44 ~6 min ios 📦tgz
✖️ 6ad38a6 #1 2023-10-12 12:51:38 ~6 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 5253173 #2 2023-10-12 13:11:13 ~2 min nix-flake 📄log
✔️ 5253173 #2 2023-10-12 13:11:40 ~2 min linux 📦deb
✖️ 5253173 #2 2023-10-12 13:11:42 ~2 min tests 📄log
✖️ 5253173 #2 2023-10-12 13:12:21 ~3 min tests 📄log
✔️ 5253173 #2 2023-10-12 13:12:34 ~3 min android 📦tgz
✔️ 5253173 #2 2023-10-12 13:14:09 ~4 min ios 📦tgz
✖️ 10547b9 #3 2023-10-12 13:42:16 ~47 sec tests 📄log
✔️ 10547b9 #3 2023-10-12 13:43:07 ~1 min linux 📦deb
✔️ 10547b9 #3 2023-10-12 13:43:46 ~2 min nix-flake 📄log
✔️ 10547b9 #3 2023-10-12 13:43:53 ~2 min tests 📄log
✔️ 10547b9 #4 2023-10-12 13:44:15 ~1 min tests 📄log
✔️ 10547b9 #3 2023-10-12 13:45:37 ~4 min android 📦tgz
✔️ 10547b9 #3 2023-10-12 13:46:08 ~4 min ios 📦tgz

Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@fbarbu15 fbarbu15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@richard-ramos richard-ramos merged commit 7826e31 into master Oct 12, 2023
11 checks passed
@richard-ramos richard-ramos deleted the fix/db/queries branch October 12, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants