fix waitForElement not waiting enough #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code for waitForElement was depending on depreacted server behaviour (Responding with a 200 OK and an empty element when a search failed) and didn't work correctly against a conforming server failing with 404 "no such element". Fix the code and add tests around this function.
|
@vbfox how is this deployed? do you have to manually push the new package to npm when you merge or is it done automatically ? |
|
I'll need to bump the version, and publish it to npm once it's merged |
When an error of type 'no such element' is detected WebDriverIO has a special handling for it and returns the error object instead of the element reference. With this fix we should handle both cases where this detection has worked and cases where it hasn't but the W3C error is still 'no such element'.
|
Turns out that there are multiple way a |
Some elements disappear briefly during animations, or the element that was matched at the start disappear to be replaced by another that happens to have the same text.
The resulting stability will be better and the API is supported contrary to getElementLocation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for
waitForElementwas depending on deprecated server behaviour (Responding with a 200 OK and an empty element when a search failed) and didn't work correctly against a conforming server failing with 404 "no such element".Fix the code and add tests around this function.