Conversation
Complete implementation of the QueryBar component for building filter expressions: - Progressive chip building flow: field → operator → value - Inline segment editing (click attribute/operator/value to edit in-place) - Multi-select value editing with dropdown checkboxes - AND/OR logical connectors between conditions - Date field support with calendar picker and range selection - Keyboard navigation (ArrowUp/Down, Enter, Escape, ArrowRight, Cmd+Arrow multi-select) - Fuzzy sort for field and value dropdown menus - Insertion gaps for adding conditions between existing chips - Error validation for unknown fields and invalid values - Comprehensive E2E and unit tests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…av and chip editing - Remove duplicate WithFooter story in DropdownMenu - Improve keyboard navigation in QueryBar menus - Fix chip editing flow and value menu state handling - Update QueryBar e2e tests - Clean up index exports Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add default clause to switch in useKeyboardNav - Replace global isNaN with Number.isNaN in useMenuFlow - Update prepare-publish config and mcp test fixtures Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Import DateValue from @ark-ui/react/date-picker instead of @zag-js/date-picker - Add non-null assertions for array access in conditions.ts - Cast item.value to ConditionValue in useValueMenuState Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Import DateValue from @ark-ui/react/date-picker instead of @zag-js/date-picker - Add non-null assertions for array access in conditions.ts - Cast item.value to ConditionValue in useValueMenuState Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> # Conflicts: # packages/design-system/src/components/QueryBar/QueryBarMenu/QueryBarDateValueMenu/DateCalendar.tsx
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
This PR is included in version 0.8.0-rc-feature-filter-attacks-components-oks.1 |
ipwallarm
reviewed
Mar 11, 2026
Collaborator
ipwallarm
left a comment
ipwallarm
left a comment
There was a problem hiding this comment.
We could merge after small changes and replace <DatePicker /> in the next step
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
This PR is included in version 0.8.0-rc-feature-filter-attacks-components-oks.2 |
Contributor
|
This PR is included in version 0.8.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
pnpm --filter design-system test🤖 Generated with Claude Code