feat(query-bar): Filter chip component: validation, keyboard interactions, and overflow behavior [AS-638]#37
Open
pigarevaoks wants to merge 7 commits intomainfrom
Open
Conversation
Complete implementation of the QueryBar component for building filter expressions: - Progressive chip building flow: field → operator → value - Inline segment editing (click attribute/operator/value to edit in-place) - Multi-select value editing with dropdown checkboxes - AND/OR logical connectors between conditions - Date field support with calendar picker and range selection - Keyboard navigation (ArrowUp/Down, Enter, Escape, ArrowRight, Cmd+Arrow multi-select) - Fuzzy sort for field and value dropdown menus - Insertion gaps for adding conditions between existing chips - Error validation for unknown fields and invalid values - Comprehensive E2E and unit tests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…av and chip editing - Remove duplicate WithFooter story in DropdownMenu - Improve keyboard navigation in QueryBar menus - Fix chip editing flow and value menu state handling - Update QueryBar e2e tests - Clean up index exports Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…rator menu - Update OPERATOR_LABELS_BY_TYPE for all field types (string, integer, float, date) - Add operator symbol Kbd badges to operator menu items (hidden for boolean) - Support custom operators list from FieldMetadata via operators prop - Set operator menu width to 256px per Figma spec Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Support `options: string[]` on FieldMetadata as shorthand for simple values and `options: []` for freeform custom value input. Space key also commits freeform values (same as Enter). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
This PR is included in version 0.10.0-rc-feature-filter-attacks-components-oks.1 |
pigarevaoks
changed the title
…ning and menu flow - Enforce single-dropdown constraint: connector chip and autocomplete menu cannot be open simultaneously - Decompose useQueryBarAutocomplete into focused sub-hooks: useFocusManagement, useInputHandlers, valueCommitHelpers - Fix dropdown Y-axis and X-axis positioning when inserting between chips - Use flushSync for menu repositioning on gap clicks and chip completion - Add continueBuilding parameter to resetState to prevent unwanted menu opens - Fix deriveAutocompleteValues to use getFieldValues instead of raw values - Memoize operatorGroups, extract constants, simplify value commit logic - Add building chip wrapper with border styling and inline input Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
This PR is included in version 0.10.0-rc-feature-filter-attacks-components-oks.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Kbdbadges and type-specific labels to the operator menu (e.g. string: "is", "like"; date: "after", "on or after")options: string[]shorthand onFieldMetadatafor simple value listsoptions: []for freeform custom value input (no dropdown, Space/Enter commits)Test plan
Kbdsymbol badges appear for all types except booleanoptions: ['GET', 'POST', ...]renders value dropdown correctlyoptions: [](freeform) skips value dropdown, Enter/Space creates chippnpm --filter design-system exec tsc --noEmit— no errorspnpm --filter design-system test— all tests pass🤖 Generated with Claude Code