feat: Table experience improvements [AS-582]#38
Open
pigarevaoks wants to merge 7 commits intomainfrom
Open
Conversation
- Restyle table header cells: align-top, py-8, leading-none, gap-0 - Add lineHeight prop to Text component - Replace xsmall Button usage with custom 16x16 buttons in table - Add theadRef + ResizeObserver for dynamic settings menu height - Add per-column renderActions/renderMenuForMoreAction via column meta - Create TableMasterCellActions component with built-in ellipsis dropdown - Add MasterCellWithActions story - Fix Link size in master cell (sm → md) - Move rounded-8 to per-size variants in ButtonBase Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Extract search input into a reusable DropdownMenuInput that renders outside the scroll area in DropdownMenuContent (like DropdownMenuFooter), preventing focus ring clipping. Use it in TableSettingsMenu. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix selected+hover row overlay to use primary-hover (8%) per Figma - Add compound selector for selected+hover state override - Remove vertical scroll bounce (overscroll-none on ScrollAreaViewport) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Extract shared tableHeaderButtonClass in classes.ts, used by TableSortHandler, TableHeadCellMenu, and TableScrollHandler - Extract ACTIONS_PL/PR/GAP/ACTION_BUTTON_SIZE constants for master cell actions padding calculation - Add comments to DropdownMenuInput explaining p-3/-m-3 ring space - Remove stale bg token from TableMasterCellActions Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
This PR is included in version 0.7.0-rc-feature-AS-582-table-experience.1 |
pigarevaoks
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
leading-none,align-top, smaller 16x16 icon buttons for sort/scroll/menu triggersrenderActions/renderMenuForMoreActionvia columnmeta, with hover-revealed action buttons, built-in ellipsis dropdown + tooltipprimary-hover8%), added compound CSS selectoroverscroll-noneon ScrollAreaViewport)lineHeightvariant (none,tight,snug,normal,relaxed)rounded-8from base to per-size variantstableHeaderButtonClass, named action layout constants, added comments for implicit CSS couplingsTest plan
MasterCellWithActionsstory, verify actions appear on row hoverTableSettingsMenu→ verify search input focus ring is not clippednpx tsc --noEmit— no type errors🤖 Generated with Claude Code