Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jira: enable tests, remove Gson usage, prep for okhttp 2.X removal #159

Merged
merged 3 commits into from
Jul 19, 2024
Merged

jira: enable tests, remove Gson usage, prep for okhttp 2.X removal #159

merged 3 commits into from
Jul 19, 2024

Conversation

benbroadaway
Copy link
Collaborator

  • not sure why unit tests were disabled, but now they back and improved
  • add new jira http client using native HttpClient
    • leverages concord-client2 for POST multipart/form-data call
    • falls back to okhttp for now, until 2.10.0+ is more widespread
  • Remove Gson dependency in favor of provided jackson

@benbroadaway benbroadaway requested review from ibodrov and a team June 21, 2024 13:36
ibodrov
ibodrov previously approved these changes Jun 22, 2024
View reviewed changes
Copy link
Collaborator

@ibodrov ibodrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor comment.

tasks/jira/src/main/java/com/walmartlabs/concord/plugins/jira/JiraTaskCommon.java Outdated Show resolved Hide resolved
@mtkunkel mtkunkel merged commit 7ecfb40 into master Jul 19, 2024
1 check passed
@mtkunkel mtkunkel deleted the jira-enable-unit-tests branch July 19, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtkunkel mtkunkel mtkunkel approved these changes

@ibodrov ibodrov ibodrov approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benbroadaway @ibodrov @mtkunkel