Skip to content

jira: enable tests, remove Gson usage, prep for okhttp 2.X removal#159

Merged
mtkunkel merged 3 commits intomasterfrom
jira-enable-unit-tests
Jul 19, 2024
Merged

jira: enable tests, remove Gson usage, prep for okhttp 2.X removal#159
mtkunkel merged 3 commits intomasterfrom
jira-enable-unit-tests

Conversation

@benbroadaway
Copy link
Copy Markdown
Collaborator

@benbroadaway benbroadaway commented Jun 21, 2024

  • not sure why unit tests were disabled, but now they back and improved
  • add new jira http client using native HttpClient
    • leverages concord-client2 for POST multipart/form-data call
    • falls back to okhttp for now, until 2.10.0+ is more widespread
  • Remove Gson dependency in favor of provided jackson

@benbroadaway benbroadaway requested review from a team and ibodrov June 21, 2024 13:36
ibodrov
ibodrov previously approved these changes Jun 22, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ibodrov ibodrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor comment.

@mtkunkel mtkunkel merged commit 7ecfb40 into master Jul 19, 2024
@mtkunkel mtkunkel deleted the jira-enable-unit-tests branch July 19, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ibodrov ibodrov ibodrov approved these changes

@mtkunkel mtkunkel mtkunkel approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benbroadaway @ibodrov @mtkunkel