Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform: remove okhttp dependency #161

Merged
merged 2 commits into from
Jul 19, 2024
Merged

terraform: remove okhttp dependency #161

merged 2 commits into from
Jul 19, 2024

Conversation

benbroadaway
Copy link
Collaborator

okhttp is only used in the (disabled) unit tests. This replaces the download manager backed with the native HttpClient.

@benbroadaway benbroadaway requested review from a team and ibodrov June 24, 2024 18:27
ibodrov
ibodrov previously approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@ibodrov ibodrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test it right now, the code LGTM.

@mtkunkel mtkunkel merged commit b7b68a3 into master Jul 19, 2024
1 check passed
@mtkunkel mtkunkel deleted the terraform-remove-okhttp branch July 19, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtkunkel mtkunkel mtkunkel approved these changes

@ibodrov ibodrov ibodrov approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benbroadaway @ibodrov @mtkunkel