Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github: log the response from GH when error occurs #170

Merged
merged 4 commits into from
Sep 26, 2024
Merged

github: log the response from GH when error occurs #170

merged 4 commits into from
Sep 26, 2024

Conversation

brig
Copy link
Contributor

@brig brig commented Aug 14, 2024

example:

java.lang.RuntimeException: Cannot merge the pull request: Method Not Allowed (405)
 response: {"message":"Pull Request is not mergeable","documentation_url":"https://docs.github.com/rest/pulls/pulls#merge-a-pull-request","status":"405"}

@brig brig requested a review from a team August 14, 2024 19:16
benbroadaway
benbroadaway previously approved these changes Aug 15, 2024
View reviewed changes
ibodrov
ibodrov previously approved these changes Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@ibodrov ibodrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, otherwise LGTM.

tasks/git/src/main/java/com/walmartlabs/concord/plugins/git/GitHubTask.java Outdated Show resolved Hide resolved
@benbroadaway benbroadaway dismissed stale reviews from ibodrov and themself via bd3ec77 September 24, 2024 15:05
@brig
Copy link
Contributor Author

brig commented Sep 24, 2024

Oh, I forgot about that PR. Thanks, Ben :)

@benbroadaway benbroadaway requested a review from a team September 26, 2024 12:40
@brig brig merged commit 50344d0 into master Sep 26, 2024
1 check passed
@brig brig deleted the brig/gh-log-response branch September 26, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbroadaway benbroadaway benbroadaway left review comments

@amithkb amithkb amithkb approved these changes

@ibodrov ibodrov ibodrov left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brig @ibodrov @benbroadaway @amithkb