Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: return comment id #189

Merged
merged 1 commit into from
Feb 10, 2025
Merged

github: return comment id #189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tasks/git/src/main/java/com/walmartlabs/concord/plugins/git/GitHubTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,17 +278,17 @@ private Map<String, Object> commentPR(Map<String, Object> in, String gitHubUri)

if (dryRunMode) {
log.info("Dry-run mode enabled: Skipping comment on PR #{} in {}/{}", gitHubPRID, gitHubOrgName, gitHubRepoName);
return Map.of();
return Map.of("id", 0);
}

log.info("Commenting PR #{} in {}/{}", gitHubPRID, gitHubOrgName, gitHubRepoName);

try {
PullRequest pullRequest = prService.getPullRequest(repo, gitHubPRID);
issueService.createComment(repo, Integer.toString(pullRequest.getNumber()), gitHubPRComment);
Comment response = issueService.createComment(repo, Integer.toString(pullRequest.getNumber()), gitHubPRComment);
log.info("Commented on PR# {}", gitHubPRID);

return Collections.emptyMap();
return Map.of("id", response.getId());
} catch (IOException e) {
throw new RuntimeException("Cannot comment on the pull request: " + e.getMessage());
}
Expand Down