jira: set user-agent for http calls

[benbroadaway]

Defaults to Concord-Jira-Plugin: <instance_id>. Can be overridden by userAgent input parameter.

[brig]

context.processInstanceId()

or is this not a process identifier?

[benbroadaway]

Not sure I understand the question/suggestion here. The overall task behavior is to use the process id (txId process variable in both runtimes). However, in runtime-v2 Context, that value is explicitly available through context.processInstanceId().

So in the task params merging (or just before), the value has to be copied into one of the input variable Maps or TaskParams would ned to be refactored to have another field for the process identifier--which seems a little unnecessary with the current big-bucket(map)-of-vars pattern.

It is decoupled enough from most of the runtime bits so that TaskParams and JiraTaskCommon could possibly used on their own.

[brig]

sry. my bad. missed this part:

policyDefaults.put("txId", context.processInstanceId());

It seemed that txId needed to be explicitly passed as an input parameter.

[benbroadaway]

Yeah it's in the growing pains of a super simple task requiring more system variables/services over time. We could further refactor JiraTaskCommon to accept another config object that covers that sort of stuff, but not coupled with the runtime (e.g. container/supplier(s) for equivalent of workDir, txId, etc) so they don't appear to be expected in: params.