concord-server: replace synchronized with locks #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brig
reviewed
Jan 2, 2025
server/impl/src/main/java/com/walmartlabs/concord/server/boot/BackgroundTasks.java
Show resolved
Hide resolved
brig
previously approved these changes
Jan 3, 2025
brig
reviewed
Jan 3, 2025
| private final SSLSocketFactory delegate; | ||
|
|
||
| public static synchronized SocketFactory getDefault() { | ||
| return new TrustingSslSocketFactory(); | ||
| public static SocketFactory getDefault() { |
There was a problem hiding this comment.
any idea why this method was synchronized?
There was a problem hiding this comment.
any idea why this method was synchronized?
I vaguely remember having issues with some SslSocketFactories that fail in constructors when created concurrently. I don't think that we have any tests that use LDAP over SSL, I'll try to test it manually -- see if perhaps we can remove the synchronization.
brig
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for virtual thread support.