Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to the
kwave
library, primarily focusing on renaming and improving the functionality of the Fourier shift interpolation method. It also includes updates to the corresponding tests to reflect these changes. The most important changes include renaming thefourier_shift
function tophase_shift_interpolate
, improving the function's documentation and implementation, and updating the test files accordingly.Function Renaming and Improvement:
fourier_shift
function tophase_shift_interpolate
and updated its implementation to improve precision and clarity. The new implementation includes better handling of dimensions and phase shifts in the Fourier domain.fourier_shift
function, advising users to usephase_shift_interpolate
instead.Test Updates:
fourierShift_test.py
which tested thefourier_shift
function.phase_shift_interpolate_test.py
to test thephase_shift_interpolate
function and ensure it works as expected. This file also includes a test to check the deprecation warning for the oldfourier_shift
function.Import and Utility Updates:
kwave/utils/math.py
to include necessary modules for the new implementation.