Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apply apodization #552

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix apply apodization #552

wants to merge 1 commit into from

Conversation

waltsims
Copy link
Owner

This pull request includes significant changes to the check_source method in the kwave/kWaveSimulation.py file to improve the handling of transducer input signals and apodization. The most important changes include renaming a parameter, reshaping the input signal, and enhancing the apodization process. closes #518

Parameter renaming:

  • Renamed kgrid_dim to k_dim in the method arguments for clarity.

Input signal handling:

  • Changed self.transducer_input_signal to a local variable transducer_input_signal and ensured it has the correct shape by reshaping it if necessary.
  • Added steps to ensure the final transducer input signal has a leading singleton dimension and transposed the last two axes for compatibility.

Apodization processing:

  • Enhanced the apodization process by using the get_transmit_apodization() method and applying the apodization to the reshaped input signal.
  • Stored the apodized input signal in self.transducer_input_signal for later use.

@waltsims waltsims changed the title Fix apply appodization Fix apply apodization Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Transmit apodization/window is never applied to transducer source.
1 participant