Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the
check_source
method in thekwave/kWaveSimulation.py
file to improve the handling of transducer input signals and apodization. The most important changes include renaming a parameter, reshaping the input signal, and enhancing the apodization process. closes #518Parameter renaming:
kgrid_dim
tok_dim
in the method arguments for clarity.Input signal handling:
self.transducer_input_signal
to a local variabletransducer_input_signal
and ensured it has the correct shape by reshaping it if necessary.Apodization processing:
get_transmit_apodization()
method and applying the apodization to the reshaped input signal.self.transducer_input_signal
for later use.