Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting the interface regarding the inventory dao layer #194

Merged
merged 4 commits into from
Nov 15, 2023

Conversation

Jzow
Copy link
Member

@Jzow Jzow commented Nov 15, 2023

No description provided.

@Jzow Jzow added the type: enhancement A general enhancement label Nov 15, 2023
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (1f8b3ca) 3.11% compared to head (3a0005a) 3.09%.
Report is 22 commits behind head on master.

Files Patch % Lines
...in/java/com/wansenai/vo/report/ProductStockVO.java 0.00% 15 Missing ⚠️
...ava/com/wansenai/dto/report/QueryProductStock.java 0.00% 5 Missing ⚠️
...ai/api/product/ProductStockKeepUnitController.java 0.00% 4 Missing ⚠️
...java/com/wansenai/api/report/ReportController.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             master    #194      +/-   ##
===========================================
- Coverage      3.11%   3.09%   -0.02%     
  Complexity       30      30              
===========================================
  Files           227     229       +2     
  Lines          4304    4325      +21     
  Branches        226     226              
===========================================
  Hits            134     134              
- Misses         4156    4177      +21     
  Partials         14      14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

private BigDecimal currentStock;

@JsonSerialize(using = BigDecimalSerializerBO.class)
private BigDecimal stockAmount;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need BigDecimal type test

@Jzow Jzow merged commit 3cb48b1 into wansenai:master Nov 15, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants