Supprimer Pipfile et Pipfile.lock #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Je n'ai pas trouvé de cas d'usage de ces fichiers, les installation et les dockerfiles faisant bon usage de pyproject.toml. Abandonnons ces fichiers.
Sans pipfile.lock, nous n'avons plus de garanties que wapiti aura été testé avec les librairies installées. Pour palier les problèmes, fixons toutes les versions. Nous ferons confiance au dépendabot pour nous prévenir quand des nouvelles versions seront disponibles.
Puisqu'on utilise que pyproject.toml, ce job peut sereinement partir en retraite.
|
Hi @devl00p, do you have an idea of a blocking point on that ? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #574 +/- ##
=======================================
Coverage 79.45% 79.45%
=======================================
Files 114 114
Lines 9506 9506
=======================================
Hits 7553 7553
Misses 1953 1953 ☔ View full report in Codecov by Sentry. |
bretfourbe
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Je n'ai pas trouvé de cas d'usage de ces fichiers, les installations et les dockerfiles faisant bon usage de
pyproject.toml. Abandonnons ces fichiers.Toutes les images se construisent sans soucis. La commande
pip3 install .fonctionne très bien. Ai-je pensé à tout ? Je suis preneur d'autre workflow qui auraient pu utiliser le Pipfile.J'en profite pour supprimer le job
Dependencies consistencyqui n'a plus lieu d'être.Pour éviter les écarts entre le développement et la production, j'ai pris le parti de fixer toutes les versions des librairies. Nous reposons déjà sur dependabot pour savoir quand mettre à jour les libs.
resolve #563