Fix the out of scope issue with swagger option #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darkiros
force-pushed
the
fix_out_of_scope_swagger_URL
branch
from
e7261fc to
90eee6f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #601 +/- ##
==========================================
- Coverage 79.52% 79.40% -0.12%
==========================================
Files 122 122
Lines 10293 10296 +3
==========================================
- Hits 8185 8176 -9
- Misses 2108 2120 +12 ☔ View full report in Codecov by Sentry. |
Darkiros
force-pushed
the
fix_out_of_scope_swagger_URL
branch
from
90eee6f to
8e4e432
Compare
bretfourbe
reviewed
Jun 27, 2024
| @@ -299,6 +299,22 @@ async def test_swagger_invalid_url(mock_browse): | |||
| mock_browse.assert_called_once() | |||
|
|
|||
|
|
|||
| @pytest.mark.asyncio | |||
| @mock.patch("wapitiCore.controller.wapiti.Wapiti.add_start_url") | |||
There was a problem hiding this comment.
add mock for attack and browse ?
Darkiros
force-pushed
the
fix_out_of_scope_swagger_URL
branch
from
8e4e432 to
199ecd2
Compare
bretfourbe
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the out of scope issue with swagger option.