-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor definitions #606
Refactor definitions #606
Conversation
32e62fc
to
6d939e3
Compare
@bretfourbe peux tu regarder les implications pour nous. |
cf83504
to
a45f81f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #606 +/- ##
==========================================
+ Coverage 79.61% 80.40% +0.78%
==========================================
Files 123 124 +1
Lines 10431 11125 +694
==========================================
+ Hits 8305 8945 +640
- Misses 2126 2180 +54 ☔ View full report in Codecov by Sentry. |
28dcc65
to
40a086f
Compare
Another significant change: the HTTP headers definitions are now split into 3 separate findings:
|
This MR refactors the attributes of each definition, which were previously held as module constants, into separate classes named "findings".
Purpose:
Parameter Simplification: Encapsulating attributes within a single class instance reduces the number of parameters - required for functions like add_payload.
The severity of a finding is not encapsulated within the finding class itself, as it may vary depending on specific circumstances.
If a finding can be categorized as both a vulnerability and an additional type, separate finding classes should be created for each category.