Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crawler: fix empty enctype case #614

Merged
merged 3 commits into from
Sep 22, 2024

Conversation

devl00p
Copy link
Contributor

@devl00p devl00p commented Sep 22, 2024

Saw since 85097cb#diff-d7e9c3756fcd51d905c37cb6d0f0ce60e24934ff30e015bde1b6a354d7e11edcR339 that requests may be sent with the "content-type" header specifying an empty value.

The MR fix that and also removes async_send that is directly handled by async_request now.

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.41%. Comparing base (f6747b4) to head (459168c).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #614      +/-   ##
==========================================
+ Coverage   80.39%   80.41%   +0.01%     
==========================================
  Files         127      127              
  Lines       11408    11380      -28     
==========================================
- Hits         9172     9151      -21     
+ Misses       2236     2229       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devl00p devl00p merged commit 357aa16 into wapiti-scanner:master Sep 22, 2024
6 of 7 checks passed
@devl00p
Copy link
Contributor Author

devl00p commented Sep 22, 2024

error could be seend in that CI: https://github.com/wapiti-scanner/wapiti/actions/runs/10593274361/job/29354416515

         "http_request": "ABC /admin/private.php HTTP/1.1\nhost: htaccess\nconnection: keep-alive\nuser-agent: Mozilla/5.0 (Windows NT 6.1; rv:45.0) Gecko/20100101 Firefox/45.0\naccept-language: en-US\naccept-encoding: gzip, deflate, br\naccept: text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,*/*;q=0.8\ncontent-type:",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant