fix: reject output conditions with unknown matcher keys#783
Open
saschabuehrle wants to merge 1 commit intowarpstreamlabs:mainfrom
Open
fix: reject output conditions with unknown matcher keys#783saschabuehrle wants to merge 1 commit intowarpstreamlabs:mainfrom
saschabuehrle wants to merge 1 commit intowarpstreamlabs:mainfrom
Conversation
gregfurman
reviewed
Mar 20, 2026
Comment on lines
+123
to
+126
| var tmpMap map[string]*docs.ParsedConfig | ||
| if tmpMap, err = pConf.FieldAnyMap(fieldOutputMetadataEquals); err != nil { | ||
| return | ||
| } |
Collaborator
There was a problem hiding this comment.
This seems reasonable to me. Can you provide an example of failing (and passing) YAML? Just want to make sure I am understanding the scope of this change correctly 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes #382. A typo in an matcher key can currently pass silently. Unknown matcher keys are dropped during parsing, leaving an empty condition map that acts as a no-op and lets the test pass.
Fix
Validation
This keeps valid test cases unchanged while failing fast on matcher typos.
Greetings, saschabuehrle