Fix/rm version file #387
Merged
Fix/rm version file #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
warrensbox
commented
Apr 24, 2024
•
warrensbox
commented
- Previous failed test show that the version that would be release would be v1.0.0 instead of 1.10
- I believe that's because we appended v to the version number, I initialized the version to be 1.1.0
- I also removed the part where the release job added the version to the version file
- Also, remove version file
warrensbox
requested review from
yermulnik,
jukie,
MatrixCrawler,
crablab and
MatthewJohn
as code owners
yermulnik
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.