Skip to content

Commit

Permalink
fix(chart): reference the correct value for the Jetstream domain (#467)
Browse files Browse the repository at this point in the history
Pull the `jetstreamDomain` value from `config.wadm.nats.jetstreamDomain`
instead of from `config.wadm.jetstreamDomain` since that is what we
define in the values file. It is also a more logical way to group the
value than what the chart was expecting.

Also bump the default version of wadm to the latest one.

Signed-off-by: Dan Norris <protochron@users.noreply.github.com>
  • Loading branch information
protochron authored Oct 24, 2024
1 parent 6f29e72 commit cfc7c45
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions charts/wadm/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: "0.2.7"
version: "0.2.8"

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
# It is recommended to use it with quotes.
appVersion: "v0.14.0"
appVersion: "v0.17.0"
4 changes: 2 additions & 2 deletions charts/wadm/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,9 @@ spec:
- name: WADM_TRACING_ENDPOINT
value: {{ .Values.wadm.config.tracingEndpoint | quote }}
{{- end }}
{{- if .Values.wadm.config.jetstreamDomain }}
{{- if .Values.wadm.config.nats.jetstreamDomain }}
- name: WADM_JETSTREAM_DOMAIN
value: {{ .Values.wadm.config.jetstreamDomain | quote }}
value: {{ .Values.wadm.config.nats.jetstreamDomain | quote }}
{{- end }}
{{- if .Values.wadm.config.maxJobs }}
- name: WADM_MAX_JOBS
Expand Down

0 comments on commit cfc7c45

Please sign in to comment.