Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add helm chart for deploying wadm on Kubernetes #248

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

joonas
Copy link
Member

@joonas joonas commented Mar 18, 2024

Feature or Problem

This adds a helm chart for deploying wadm on Kubernetes

Related Issues

Release Information

Consumer Impact

Testing

Unit Test(s)

Acceptance or Integration

Manual Verification

Copy link
Contributor

@thomastaylor312 thomastaylor312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small change around how to expose configuration options

charts/wadm/values.yaml Outdated Show resolved Hide resolved
charts/wadm/values.yaml Outdated Show resolved Hide resolved
@joonas joonas force-pushed the joonas/add-helm-chart branch 4 times, most recently from 4645b48 to d9c9804 Compare March 28, 2024 18:24
@joonas
Copy link
Member Author

joonas commented Mar 28, 2024

@thomastaylor312 I believe I've got all of your feedback addressed, PTAL

Copy link
Contributor

@thomastaylor312 thomastaylor312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically there, just one more small change

charts/wadm/templates/deployment.yaml Outdated Show resolved Hide resolved
Signed-off-by: Joonas Bergius <joonas@cosmonic.com>
@thomastaylor312 thomastaylor312 enabled auto-merge (squash) April 1, 2024 17:49
@thomastaylor312 thomastaylor312 merged commit ea900d0 into wasmCloud:main Apr 1, 2024
7 checks passed
@joonas joonas deleted the joonas/add-helm-chart branch April 30, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants