PR #3855 reopened #3897
Merged
PR #3855 reopened #3897
+86
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Clippy issue will be fixed after #3898 merges, I will rebase |
ricochet
approved these changes
Dec 31, 2024
|
Looks like you'll have to correct the conventional commit formatting for these commits too |
thomastaylor312
approved these changes
Dec 31, 2024
brooksmtownsend
force-pushed
the
PsychoPunkSage/main
branch
2 times, most recently
from
19228a7 to
43704c7
Compare
…guration Signed-off-by: Abhinav Prakash <abhinav.prakash319@gmail.com> Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com> fix: Proper logic of Paths resolution Signed-off-by: Abhinav Prakash <abhinav.prakash319@gmail.com> Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com> fix: replaced all std::env::current_dir() references in wash-cli Signed-off-by: Abhinav Prakash <abhinav.prakash319@gmail.com> Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com> fix: Changed the impl acc to discussion Signed-off-by: Abhinav Prakash <abhinav.prakash319@gmail.com> Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com> fix: publically exposed the config-path Signed-off-by: Abhinav Prakash <abhinav.prakash319@gmail.com> Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com> fix: Cleanupgit add crates/wash-cli/src/cmd/dev/mod.rs crates/wash-cli/src/cmd/mod.rs crates/wash-cli/src/cmd/wit/build.rs crates/wash-cli/src/cmd/wit/deps.rs crates/wash-lib/src/parser/mod.rs Signed-off-by: Abhinav Prakash <abhinav.prakash319@gmail.com> Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com> fix: Cleanupgit add crates/wash-cli/src/cmd/config/mod.rs Signed-off-by: Abhinav Prakash <abhinav.prakash319@gmail.com> Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
brooksmtownsend
force-pushed
the
PsychoPunkSage/main
branch
from
43704c7 to
dc05d4a
Compare
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
brooksmtownsend
force-pushed
the
PsychoPunkSage/main
branch
from
dc05d4a to
858457d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Abhinav Prakash abhinav.prakash319@gmail.com
Feature or Problem
It appears I am not a git wizard, and there's something up that closes PR #3855. These are all of the original commits from there by @PsychoPunkSage, who did a great job here, I just had to rebase the branch due to a conflict.
Related Issues
Originally #3855
Fixes #3800
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification