feat(host): builtin http-server path routing #3924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksmtownsend
force-pushed
the
feat/builtin-http-path-mode
branch
2 times, most recently
from
9607548 to
1c3fd27
Compare
brooksmtownsend
force-pushed
the
feat/builtin-http-path-mode
branch
from
1c3fd27 to
3bdbc82
Compare
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com> feat(host): implement path based routing Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
brooksmtownsend
force-pushed
the
feat/builtin-http-path-mode
branch
from
3407d2f to
3e19e9d
Compare
rvolosatovs
previously requested changes
Jan 14, 2025
rvolosatovs
reviewed
Jan 14, 2025
rvolosatovs
reviewed
Jan 14, 2025
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
|
@rvolosatovs reintroduced the |
rvolosatovs
reviewed
Jan 14, 2025
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
thomastaylor312
approved these changes
Jan 16, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Something is mad: https://github.com/wasmCloud/wasmCloud/actions/runs/12830733705/job/35780437640
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This PR refactors the builtin HTTP server for code reuse and adds an implementation for path-based routing. This uses the same link configuration and handling code as the native binary HTTP server and should be a drop-in replacement for path-based application yamls.
Related Issues
Fixes #3741
Release Information
wasmCloud 1.6.0
Consumer Impact
Testing
Unit Test(s)
Included a unit test to validate the link handling. https://github.com/wasmCloud/wasmCloud/actions/runs/12601826784/job/35123739425?pr=3924#step:4:2173
Acceptance or Integration
Marked as draft while I write an integration test for actually testing path routing.
Manual Verification