chore: update README with latest version, example policy topic #32
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
| @@ -45,7 +45,7 @@ apiVersion: v1 | |||
| kind: Secret | |||
| metadata: | |||
| name: my-wasmcloud-cluster | |||
| data: | |||
| stringData: | |||
There was a problem hiding this comment.
does this change impact the nats.creds section below?
There was a problem hiding this comment.
Yeah, removed the base64 bit
There was a problem hiding this comment.
Given the format of the nats.creds, we should decide if it needs to be nats.creds: | or just base64 encoded string that we could then unpack (I think we should be able to check if it's base64 encoded or not before we store it), wdyt?
Alternatively I suppose we could consider providing an option for secret reference to pull them from, maybe that's a future iteration.
README.md
Outdated
| ``` | ||
|
|
||
| ### Start the operator | ||
|
|
||
| ```sh | ||
| kubectl kustomize build deploy/local | kubectl apply -f - | ||
| kubectl kustomize deploy/local | kubectl apply -f - |
There was a problem hiding this comment.
I'm not sure if this is intended for running it locally vs. "production", but if it's the latter, should this reference the helm chart instead of kustomize?
I know there's a philosophical debate about this that could be had, but kustomize feels more appropriate for local development vs. helm for production.
There was a problem hiding this comment.
It should be base actually, not local. I'll fix that
| @@ -45,7 +45,7 @@ apiVersion: v1 | |||
| kind: Secret | |||
| metadata: | |||
| name: my-wasmcloud-cluster | |||
| data: | |||
| stringData: | |||
There was a problem hiding this comment.
Given the format of the nats.creds, we should decide if it needs to be nats.creds: | or just base64 encoded string that we could then unpack (I think we should be able to check if it's base64 encoded or not before we store it), wdyt?
Alternatively I suppose we could consider providing an option for secret reference to pull them from, maybe that's a future iteration.
Signed-off-by: Dan Norris <protochron@users.noreply.github.com>
Feature or Problem
See title
Related Issues
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification