Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Making issuers & secret optional #68

Merged
merged 3 commits into from
Jul 11, 2024
Merged

refactor: Making issuers & secret optional #68

merged 3 commits into from
Jul 11, 2024

Conversation

lxfontes
Copy link
Member

@lxfontes lxfontes commented Jul 9, 2024

Continuation of #67

Moving secretName and issuers to optional since they are no longer needed as of 1.0 wasmCloud/wasmCloud@bc5d296

We still mount the secretName for nats credentials when specified.

lxfontes
lxfontes commented Jul 9, 2024
View reviewed changes
src/controller.rs Outdated Show resolved Hide resolved
@lxfontes lxfontes mentioned this pull request Jul 9, 2024
Closed
joonas
joonas approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@joonas joonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good to me 👍

ricochet and others added 2 commits July 10, 2024 09:59
@ricochet @lxfontes
refactor: Making issuers & secret optional
485f81d 
Ref:
[`bc5d296`](wasmCloud/wasmCloud@bc5d296)

BREAKING CHANGE: Host no longer uses cluster seed as of 1.0.

Signed-off-by: Bailey Hayes <behayes2@gmail.com>

refactor: Making issuers & secret optional

removing

Signed-off-by: Lucas Fontes <lucas@cosmonic.com>
@lxfontes
Refactoring var names & adding deprecation notice.
9986846 
Signed-off-by: Lucas Fontes <lxfontes@gmail.com>
Signed-off-by: Lucas Fontes <lucas@cosmonic.com>
@lxfontes lxfontes force-pushed the lxfontes/remove-cluster-seed branch from 2a088d8 to 9986846 Compare July 10, 2024 12:59
protochron
protochron approved these changes Jul 10, 2024
View reviewed changes
src/controller.rs Outdated Show resolved Hide resolved
@lxfontes
Secret defaults the right way
3478083 
Signed-off-by: Lucas Fontes <lxfontes@gmail.com>
@lxfontes lxfontes force-pushed the lxfontes/remove-cluster-seed branch from 541e095 to 3478083 Compare July 10, 2024 15:01
@joonas joonas merged commit 4f4bde8 into wasmCloud:main Jul 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@protochron protochron protochron approved these changes

@joonas joonas joonas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lxfontes @joonas @protochron @ricochet