-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New auth model docs #1620
New auth model docs #1620
Conversation
Signed-off-by: Mihovil Ilakovac <mihovil@ilakovac.com>
Signed-off-by: Mihovil Ilakovac <mihovil@ilakovac.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@infomiho nice job all together, I think this is in good shape, I left some comments, some are on docs, some on Auth in general due to me understanding some stuff better, check it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! There are some conflicts, due to me merging release
with the updated docs into the main
. I had to fix some links, so that is probably the cause of the conflicts. If you are not sure how to solve them, let me know, I can help, although it should be relatively simple.
Docs changes required for the auth model changes done in #1583
Left to do
user
username