Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New auth model docs #1620

Merged
merged 16 commits into from
Jan 15, 2024
Merged

New auth model docs #1620

merged 16 commits into from
Jan 15, 2024

Conversation

infomiho
Copy link
Contributor

@infomiho infomiho commented Jan 6, 2024

Docs changes required for the auth model changes done in #1583

  • Removed the old auth model mentions
  • Described the new auth model in a separate page
  • Updated the texts for auth methods
  • Added mentions of the new auth model in relevant places

Left to do

  • Go though the tutorial
  • Go through each auth provider one more time
  • Add a section on the way to use the user
    • Server
    • Client
    • New helpers to get the e.g. username

web/docs/auth/email.md Outdated Show resolved Hide resolved
Signed-off-by: Mihovil Ilakovac <mihovil@ilakovac.com>
Copy link
Member

@Martinsos Martinsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@infomiho nice job all together, I think this is in good shape, I left some comments, some are on docs, some on Auth in general due to me understanding some stuff better, check it out.

web/docs/auth/email.md Outdated Show resolved Hide resolved
web/docs/auth/email.md Outdated Show resolved Hide resolved
web/docs/auth/email.md Show resolved Hide resolved
web/docs/auth/email.md Outdated Show resolved Hide resolved
web/docs/auth/email.md Show resolved Hide resolved
web/docs/auth/username-and-pass.md Show resolved Hide resolved
web/docs/tutorial/07-auth.md Outdated Show resolved Hide resolved
web/docs/tutorial/07-auth.md Outdated Show resolved Hide resolved
web/src/components/Internal.tsx Outdated Show resolved Hide resolved
web/src/components/Required.tsx Outdated Show resolved Hide resolved
Copy link
Member

@Martinsos Martinsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! There are some conflicts, due to me merging release with the updated docs into the main. I had to fix some links, so that is probably the cause of the conflicts. If you are not sure how to solve them, let me know, I can help, although it should be relatively simple.

@infomiho infomiho merged commit ffe2509 into main Jan 15, 2024
@infomiho infomiho deleted the miho-new-auth-docs branch January 15, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants