Upgrade pydantic #108
Merged
Upgrade pydantic #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inding entrypoints
lbianchi-lbl
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
As far as I can tell the changes look good. @MichaelPesce do you need to revert some of the changes (e.g. to .github/workflows) before merging? If so, I'll let you merge whenever you prefer. If it makes a difference for testing, watertap-org/watertap#1330 has been merged.
|
@lbianchi-lbl Yup I'll revert some of those changes and test this PR with watertap main before merging. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relies on watertap PR #1330