Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update parameter sweep to use action_wrapped solve function #133

Merged
merged 6 commits into from
Aug 16, 2024
Merged

Update parameter sweep to use action_wrapped solve function #133

merged 6 commits into from
Aug 16, 2024

Conversation

MichaelPesce
Copy link
Collaborator

  • use action_wrapped solve function for parameter sweep instead of attempting to dynamically locate solve function
  • helps solve the underlying problem that led to the need for Add test for parameter sweep #93
  • relies on watertap PR #1475

@MichaelPesce MichaelPesce changed the title Parameter sweep test Update parameter sweep to use action_wrapped solve function Aug 2, 2024
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Aug 8, 2024
@MichaelPesce MichaelPesce marked this pull request as ready for review August 14, 2024 00:42
@MichaelPesce MichaelPesce merged commit 86ef1dc into watertap-org:main Aug 16, 2024
4 checks passed
@MichaelPesce MichaelPesce mentioned this pull request Aug 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MichaelPesce MichaelPesce

Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelPesce @ksbeattie