Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major SDK Release 13.0.0 #1228

Merged
merged 3 commits into from
May 20, 2024
Merged

Major SDK Release 13.0.0 #1228

merged 3 commits into from
May 20, 2024

Conversation

apaparazzi0329
Copy link
Contributor

No description provided.

@apaparazzi0329 apaparazzi0329 requested a review from kevinkowa May 16, 2024 15:17
kevinkowa
kevinkowa previously approved these changes May 17, 2024
Copy link
Contributor

@kevinkowa kevinkowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a comment if that is a breaking change and willing to introduce it into a minor release

Comment on lines 234 to -239
private Float backgroundAudioSuppression;
private Boolean lowLatency;
private Float characterInsertionBias;
private Boolean interimResults;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't that be considered a breaking change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. For the java-sdk this is a breaking change. I hate to have a major release for such a small change but it would be necessary

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another important question. Do we skip to version 14 for good luck 😂

@apaparazzi0329 apaparazzi0329 changed the title Minor SDK Release 12.1.0 Major SDK Release 13.0.0 May 17, 2024
BREAKING CHANGE: RecognizeWithWebsocketsOptions interimResults and
lowLatency properties removed
Copy link
Contributor

@kevinkowa kevinkowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@apaparazzi0329 apaparazzi0329 merged commit 4c571c2 into master May 20, 2024
4 checks passed
@apaparazzi0329 apaparazzi0329 deleted the sdk-release-12.1.0 branch May 20, 2024 15:45
@watson-github-bot
Copy link
Member

🎉 This PR is included in version 13.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants