-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major SDK Release 13.0.0 #1228
Major SDK Release 13.0.0 #1228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a comment if that is a breaking change and willing to introduce it into a minor release
private Float backgroundAudioSuppression; | ||
private Boolean lowLatency; | ||
private Float characterInsertionBias; | ||
private Boolean interimResults; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't that be considered a breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. For the java-sdk this is a breaking change. I hate to have a major release for such a small change but it would be necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another important question. Do we skip to version 14 for good luck 😂
BREAKING CHANGE: RecognizeWithWebsocketsOptions interimResults and lowLatency properties removed
1024518
to
e671e39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
🎉 This PR is included in version 13.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.