Adds version() function #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wavded
approved these changes
Sep 3, 2024
|
@molynerd Thanks so much. Sorry I was busy and then on vacation so did not get to this till now. I think this will work for now, is simple and unobtrusive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #107
what I like
It's fairly concise and easy to use.
what I don't like
It doesn't honor the
commandarg on the default function and I don't think it should either. The point ofversion()is to understand what the lib is going to do by default. Ideally, it's something that you log or store for triage purposes. If an implementer is callingogr2ogrfrom a novel location, I suspect that knowing the version number isn't something they're interested in. Additionally, honoring thecommandarg would require significant rework of the default function, as theinputarg would not make sense in the context of getting the version of the command line utility. Alternatively, one could argue that theversionfunction could simply take in acommandarg and solve this problem, but I'm not sure if that's desired. Happy to take feedback here.