-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement NEO-DFT on host #92
base: master
Are you sure you want to change the base?
Conversation
Note that epc17 and epc18 are available in libxc master
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass, great start!
src/xc_integrator/replicated/host/reference_replicated_xc_host_integrator_exc_vxc.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once UTs pass, I'll do a proper review.
NEO DFT PR is ready for review (in-house epc is used right now. API for libxc via exchcxx will come later). MPI tests are failing at the moment. However, if protonic screening is turned off, then MPI can recover the same energy as single node |
This is for prepare for later implementation of EPC19
This PR adds functionality to do electron-proton correlation (EPC) functional in GauXC, thus allowing nuclear-electronic orbital (NEO) DFT calculations.
Changes:
Modified
loadBalancer
to store 2 basis.Modified
XCIntegrator
to also take aepcfunctional
.Added
neo_eval_exc_vxc
function is added. UKS is forced for protonic to ensure high spin configuration for protons. Electronic system can be either RKS or UKS.Protonic basis screening, collocation evaluation, xmat evaluation, density evaluation... are all carried out using the existing machinery.
Available EPC functionals are:
EPC17_1
,EPC18_2
,EPC18_1
,EPC18_2
. These are done using the Builtin backend of ExchCXX (Add Builtin LDA Electron-Proton Correlation Functionals ExchCXX#38).References:
EPC17-1, EPC17-2, EPC18-1 and EPC18-2
EPC17_1, EPC17_2, EPC18_1, EPC18_2 functional is benchmarked against PySCF implementation.
Settings: water molecule, H radius set to 52.9 pm, sto-3g/prot-sp basis, RB3LYP + unrestricted EPC functionals, (99,590) Lebedev grid with no pruning, MuraKnowles radial quadrature, and Becke weights. PySCF set to 1e-15 energy convergence, GauXC set to 1e-10 RMSDP convergence
EPC17_2 functional is additionally benchmarked against Chronus Quantum implementation.
Settings: COH2 molecule, H radius set to 52.9 pm, cc-pvdz/prot-pb4-d basis, RBLYP + unrestricted EPC17_2 functionals, (99,590) Lebedev grid with no pruning, MurrayHandyLeming radial quadrature, and Becke weights. CQ and GauXC set to 1e-10 RMSDP convergence
Device code NYI