-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] C API #83
base: master
Are you sure you want to change the base?
[WIP] C API #83
Conversation
@@ -0,0 +1,146 @@ | |||
#pragma once |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be a good idea to use the standard C approach here, as #pragma once
appears to be compiler dependent..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a compiler doesn't support pragma once
, the rest of the stack won't compile either. This is a conscious design decision. Show me a modern compiler that doesn't support pragma once
, and we can reconsider that choice. From this list, it seems that everything that we can reasonably support supports this paradigm
https://en.m.wikipedia.org/wiki/Pragma_once
NB, This may preclude some embedded compilers/platforms, but the fact that we're doing dynamic memory management (i.e. calls to malloc
/new
) already precludes them - if there's a reason to target these platforms, we'd have to do a rather large overhaul of everything and pragma once
would be the least of our problems.
@@ -0,0 +1,146 @@ | |||
#pragma once |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a compiler doesn't support pragma once
, the rest of the stack won't compile either. This is a conscious design decision. Show me a modern compiler that doesn't support pragma once
, and we can reconsider that choice. From this list, it seems that everything that we can reasonably support supports this paradigm
https://en.m.wikipedia.org/wiki/Pragma_once
NB, This may preclude some embedded compilers/platforms, but the fact that we're doing dynamic memory management (i.e. calls to malloc
/new
) already precludes them - if there's a reason to target these platforms, we'd have to do a rather large overhaul of everything and pragma once
would be the least of our problems.
…rature RSCAL getter + UT
I've been staring at this and can't find the difference...?
Neither can I, that’s my point. I don’t see any difference in these functions. The first one is different, the later ones are identical except the function name…
|
@susilehtola Ohhh, I see. That was just because it wasn't fleshed out - the differences are apparent now |
No description provided.