Skip to content

Commit

Permalink
Fix color regressions (#475)
Browse files Browse the repository at this point in the history
* fix color regressions

* separate app status vars
  • Loading branch information
adred authored Mar 19, 2024
1 parent b24c811 commit accb74a
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 7 deletions.
2 changes: 2 additions & 0 deletions public/themes/default.css
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@
--app-icon-color: rgb(139, 145, 138);
--app-icon-hover-color: #fff;
--app-selected-mask-color: rgba(255, 255, 255, 0.06);

/* global status colors */
--app-error-color: rgb(229, 77, 46);
--app-warning-color: rgb(224, 185, 86);
--app-success-color: rgb(78, 154, 6);
Expand Down
3 changes: 0 additions & 3 deletions public/themes/light.css
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,6 @@
--button-primary-color: #fefefe;
--button-secondary-bg-color: rgba(200, 200, 200, 0.3); /* Semi-transparent light gray */

/* view colors */
--app-text-color: var(--app-text-color);

/* table colors */
--table-thead-border-top-color: rgba(0, 0, 0, 0.2);
--table-thead-border-bottom-color: rgba(0, 0, 0, 0.3);
Expand Down
2 changes: 1 addition & 1 deletion src/app/app.less
Original file line number Diff line number Diff line change
Expand Up @@ -756,7 +756,7 @@ a.a-block {
.status-icon.status-error {
path,
circle {
fill: var(--app-text-disabled-color);
fill: var(--app-error-color);
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/app/common/elements/button.less
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
}

&.secondary.danger {
color: var(--app-text-disabled-color);
color: var(--app-error-color);
}

&.small {
Expand Down
2 changes: 1 addition & 1 deletion src/app/common/elements/status.less
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
}

.dot.red {
background-color: var(--app-text-disabled-color);
background-color: var(--app-error-color);
}

.dot.gray {
Expand Down
2 changes: 1 addition & 1 deletion src/app/common/icons/icons.less
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ The following accounts for a debounce in the status indicator. We will only disp
}
&.error #indicator {
visibility: visible;
fill: var(--app-text-disabled-color);
fill: var(--app-error-color);
}
&.success #indicator {
visibility: visible;
Expand Down

0 comments on commit accb74a

Please sign in to comment.