Packetparser Ignore Spurious Invalid Input at Beginning of Stream #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… packet. the complication here was ensuring we always output a real packet in every flow so we don't actually lose valid errors.
|
Short, question. I have an ssh server configured with a banner message at connect. I get an error like this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for #99. Add a flag to have the parser ignore spurious input that happens before seeing a real packet. Normally that spurious input is converted in a RawPacket. Those RawPackets cause connection errors (since the code on the other side is waiting for an InitPacket). This flag will let the parser ignore input until it sees a valid packet.
We also need to force all of the paths that use this new flow to output a valid packet. That's why I added the "ping" packets in the mshell commands.