New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drag and drop support for tabs #146

Merged

sawka merged 26 commits into main from tabs-drag-n-drop

Dec 15, 2023

Member

adred commented Dec 14, 2023

No description provided.

adred added 8 commits

December 13, 2023 15:08


          back-end implementation. initial ui implementation

f86f4c0


          rough implementation of drag and drop

d156a64


          wrap with AnimatePresence

24ab0cf


          persist screen order

f4d0cca


          cleanup

c833175


          return all screens when updating indices

5f4d135


          remove y axis anitation

37df807


          remove debugging code

0f03d06

adred requested a review from sawka

December 14, 2023 23:24

adred self-assigned this

adred added 7 commits

December 15, 2023 07:33


          chain filtering and sorting logic

84580ec


          remove unused var

12f3cce


          fix issue where tabs shift to left on hover

788161c


          fix tabElem scroll into view regression

1a2587c


          clear scrollIntoViewTimeout when component unmounts

f054d05


          remove borken style prop

51f5c48


          completely remove animation related props

c44e4eb

sawka reviewed

View reviewed changes

src/app/workspace/screen/tabs.tsx Outdated Show resolved Hide resolved

sawka reviewed

View reviewed changes

src/model/model.ts Outdated Show resolved Hide resolved

sawka reviewed

View reviewed changes

src/model/model.ts Outdated Show resolved Hide resolved

sawka reviewed

View reviewed changes

src/model/model.ts Outdated Show resolved Hide resolved

sawka reviewed

View reviewed changes

src/model/model.ts Outdated Show resolved Hide resolved

sawka reviewed

View reviewed changes

wavesrv/pkg/cmdrunner/cmdrunner.go Outdated Show resolved Hide resolved

sawka reviewed

View reviewed changes

wavesrv/pkg/cmdrunner/cmdrunner.go Show resolved Hide resolved

adred added 6 commits

December 15, 2023 10:21


          scroll into view only when there's a new tab

4e5847e


          minor comment fix

f22d55f


          resolvePosInt() to resolve index

4ca3e68


          move tab width const to magiclayout.ts

731b629


          move back scroll into view code as it was before


          clear timout

a9256ec

adred added 5 commits

December 15, 2023 10:51


          refactor setTimeout

f68f3b7


          remov debugging codes

a803fa4


          format cmdrunner.go

9d334df


          move clearTimeout

2a0ab03


          remove wheel event listener

bee9e78

sawka merged commit ea9cb37 into main

4 checks passed

sawka deleted the tabs-drag-n-drop branch

September 18, 2024 19:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet