fix: schema build process ignore rmrf error #1897
Conversation
In prod builds, the RMRF step of build:schema is breaking the build. This ignores the error produced to avoid that.
|
Warning Rate limit exceeded@oneirocosm has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 10 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThe changes update a configuration task by modifying its error-handling behavior. A new parameter, Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Taskfile.yml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
Taskfile.yml
[error] 127-127: syntax error: expected , but found ''
(syntax)
🪛 GitHub Actions: Test Build Docsite and Storybook
Taskfile.yml
[error] 124-124: Failed to parse Taskfile.yml: did not find expected '-' indicator.
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Analyze (go)
- GitHub Check: Build for TestDriver.ai
Taskfile.yml
Outdated
| - go run cmd/generateschema/main-generateschema.go | ||
| - '{{.RMRF}} "dist/schema"' | ||
| ignore_error: true | ||
| - task: copyfiles:'schema':'dist/schema' |
There was a problem hiding this comment.
Critical: YAML Syntax Error in the Command Element
The newly added ignore_error: true (line 127) is causing a YAML syntax error because it is attached to a scalar list item instead of being part of a mapping. Each list element in the cmds array must be consistently defined as either a scalar or an object. In this case, to add the ignore_error property, you need to refactor the scalar command into a mapping.
Below is a suggested diff to fix the YAML syntax:
- - '{{.RMRF}} "dist/schema"'
- ignore_error: true
+ - cmd: '{{.RMRF}} "dist/schema"'
+ ignore_error: trueThis refactoring ensures that the command and its properties are correctly structured as a mapping, which should resolve the YAML parsing errors indicated by both YAMLlint and the pipeline.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - go run cmd/generateschema/main-generateschema.go | |
| - '{{.RMRF}} "dist/schema"' | |
| ignore_error: true | |
| - task: copyfiles:'schema':'dist/schema' | |
| - go run cmd/generateschema/main-generateschema.go | |
| - cmd: '{{.RMRF}} "dist/schema"' | |
| ignore_error: true | |
| - task: copyfiles:'schema':'dist/schema' |
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 127-127: syntax error: expected , but found ''
(syntax)
In prod builds, the RMRF step of build:schema is breaking the build. This ignores the error produced to avoid that.